Hi Al, >> Regarding the issue of custom setters for the obsoleted variable >> preview-leave-open-previews-visible, here's a diff (on top of your >> latest patch) indicating how this might be done: > Since you seem to be wanting the setting of `preview-keep-stale-images` > to change the variables only when set to non-nil, then perhaps a custom > setter is sufficient after all? Or are you wanting to handle setq as well?
Yeah, I figured that'd be most convenient, since I feel like most people use setq. > It would be difficult for me to test all possible async paths. But the > purpose of this statement is to select the truly selected buffer in the > window, rather than a temporarily selected one since > `preview-overlay-updated` itself is/might be called inside a different > `with-current-buffer`. > > I can't use (overlay-buffer ov) since the point is for > `preview--update-buframe` to display the buframe if the currently > selected buffer in the window is equal to the overlay buffer. Maybe one scenario to think through is if the user is generating previews while switching between buffers. I noticed some issues while doing that over the past few weeks, but haven't yet taken the time to track down or think about whether they might be due to your patch. Of course this can be addressed after your patch lands. > I copied this verbatim from `preview-generate-preview` (the last form in > the function). Should I change both? Might as well, at least from my POV. Thanks, best, Paul _______________________________________________ bug-auctex mailing list [email protected] https://lists.gnu.org/mailman/listinfo/bug-auctex
