Eric Blake wrote: > According to Jim Meyering on 10/9/2009 2:56 PM: >>> For each library chunk, the comment lists something to grep for; any time we >>> add a new gnulib module that adds another library dependency, it should be >>> easier to grep for anyone that uses that function, and update the library >>> section accordingly. >> >> Nice change. Go ahead. > > And with it checked in, I discovered that I missed stdbuf, and that gnulib > recommends a couple of other libraries. Since the build is broken without > the stdbuf fix, I'm pushing this, too.
Thanks. BTW, do you normally test on Linux? Or maybe you did, but using --disable-acl? ls was failing to link due to omitted -lacl. I've just pushed this: >From c9e7b8844b8c5c9e073d21cde57e945eda5ea2c2 Mon Sep 17 00:00:00 2001 From: Jim Meyering <[email protected]> Date: Sat, 10 Oct 2009 08:24:02 +0200 Subject: [PATCH] build: ls: fix link failure due to missing -lacl * src/Makefile.am (ls_LDADD): Re-add $(LIB_ACL). Inadvertently-removed by commit 78c93601. --- src/Makefile.am | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index ed7cc86..aee904f 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -273,6 +273,7 @@ su_LDADD += $(LIB_CRYPT) # for various ACL functions copy_LDADD += $(LIB_ACL) dir_LDADD += $(LIB_ACL) +ls_LDADD += $(LIB_ACL) # for various xattr functions copy_LDADD += $(LIB_XATTR) -- 1.6.5.rc3.206.g54797
