According to Jim Meyering on 10/10/2009 12:43 AM: >> And with it checked in, I discovered that I missed stdbuf, and that gnulib >> recommends a couple of other libraries. Since the build is broken without >> the stdbuf fix, I'm pushing this, too. > > Thanks. > > BTW, do you normally test on Linux? > Or maybe you did, but using --disable-acl?
I did, but it was an old enough machine that -lacl wasn't present, so configure disabled the attempt to do that link in the first place. Sorry about that. > diff --git a/src/Makefile.am b/src/Makefile.am > index ed7cc86..aee904f 100644 > --- a/src/Makefile.am > +++ b/src/Makefile.am > @@ -273,6 +273,7 @@ su_LDADD += $(LIB_CRYPT) > # for various ACL functions > copy_LDADD += $(LIB_ACL) > dir_LDADD += $(LIB_ACL) > +ls_LDADD += $(LIB_ACL) Hmm. dir_LDADD is a no-op - it was previously assigned to be identical to whatever the final ls_LDADD ends up being (ie. my bug was using dir_LDADD instead of the correct ls_LDADD). Therefore, should I also apply this patch (just a diff for now)? diff --git a/src/Makefile.am b/src/Makefile.am index b4ff8da..915ea81 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -361,7 +361,6 @@ su_LDADD += $(LIB_CRYPT) # for various ACL functions copy_LDADD += $(LIB_ACL) -dir_LDADD += $(LIB_ACL) ls_LDADD += $(LIB_ACL) # for various xattr functions -- Don't work too hard, make some time for fun as well! Eric Blake [email protected]
signature.asc
Description: OpenPGP digital signature
