On 09/26/2011 04:04 PM, Eric Blake wrote:
On 09/26/2011 03:47 PM, Reuben Thomas wrote:
Is linebuffer obsoleteable in the face of standardized getline and
friends?
Not necessarily, because linebuffer provides a slightly different
interface that might be easier to use. However, I do argue that both
linebuffer and getdelim can be written MUCH more efficiently, by doing
it in terms of freadahead and friends, rather than by one getc() at a time.
More to the point, I did the same conversion to getndelim2 back in 2008,
and it made a very nice difference to cut:
https://lists.gnu.org/archive/html/bug-coreutils/2008-04/msg00372.html
So _both_ linebuffer and getdelim would benefit from a conversion to
freadptr.
--
Eric Blake ebl...@redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
