On 2025-11-24 15:33, Bruno Haible wrote:
msvc14/usr/include/WDBGEXTS.H:#define dprintf
(ExtensionApis.lpOutputRoutine)
minix-3.3.0/usr/include/x86/mutex.h:#define mtx_lock
u.s.mtxs_lock
netbsd-10.0/usr/include/x86/mutex.h:#define mtx_lock
u.s.mtxs_lock
The MSVC instance surely is not a problem, as WDBGEXTS.H is a MS-Windows
hardware driver include file that is not intended to be used by
Gnulib-using apps. The NetBSD instance is not a problem either, as it is
inside an '#ifdef __MUTEX_PRIVATE' and user apps aren't supposed to mess
with __MUTEX_PRIVATE. I assume the Minix one is similar to the NetBSD one.
The last one produces a diagnostic, but unfortunately
_GL_WARN_ID_LIKE (u.v.w)
_GL_WARN_ID_LIKE (u;v;w)
don't give a warning or error.
But _GL_WARN_ON_USE would produce an error, right? So we should be OK
with these anyway, in the sense that we shouldn't have the sort of
silent failures that I thought was the worry here.
- The second patch is fine, except for 'dprintf' and 'mtx_lock'. For these
two, it's better to keep the '#undef'.
Perhaps my discussion above is enough evidence that dprintf and mtx_lock
are not problems in practice. In the meantime I installed the second
patch with those small changes you suggested.
