On 2025-11-25 04:30, Bruno Haible wrote:
Regarding dprintf, however, it seems that the programmers community at large is defining dprintf as a macro in more than 100 of packages [1]. So, it seems wise to keep the #undef for this one.
OK, I kept #undef for dprintf but removed it for mtx_lock.
But _GL_WARN_ON_USE would produce an error, right? So we should be OK with these anyway, in the sense that we shouldn't have the sort of silent failures that I thought was the worry here.Right. So, I agree to put in this _GL_WARN_ID_LIKE check, but with a clarification that - its argument is not necessarily a single token, - it does not check for "identifier-like" but only for certain characters such as parentheses.
On further reflection I don't see realistic problems that this would catch but would go uncaught with things as-is. So for now, in the interest of simplicity, I left things alone here.
