Many thanks for your great work!
From: Christoph Plattner <[EMAIL PROTECTED]>
Subject: Here is the running GRUB DISKLESS stuff
Date: Wed, 05 Apr 2000 01:27:44 +0200
> Please give me a hint, how can I use the automake,etc,
> environment.
Have you read the manual? The GRUB's build environment is somewhat
tricky, but basically we use the normal features of Automake.
> The ./configure script should get something like
>
> --enable-diskless
>
> and set the -DGRUB_DISKLESS (not implemented yet, I added
> -DGRUB_DISKLESS to the 'NET_CONFIG' to test in the
> 'stage2/Makefile' and 'netboot/Makefile'.
See how the netboot stuff works. You can do nearly the same thing.
> *** By the way, I patched a fix in builtin.c, where 'grub_memcmp'
> *** used instead of 'grub_strcmp'. !!!
Ah, sorry, I forgot to add the `size' argument. Your fix is
incorrect, because the strings are not nul-terminated. I'll fix it
soon.
BTW, I must mention several things. First of all, please write
ChangeLog entries for your changes. The convention is documented in
the GNU Coding Standards. In principle, you can "mimic" the existing
entries. Second, you should comply with the GNU C style. This is also
documented in the standards. Third, why do you create another buffer
for the configuration file name? Can't you just use CONFIG_FILE?
Fourth, it is not very good to call builtin commands directly, since
GRUB sometimes assumes that some initialization code is done before
any builtin command is called. Instead, you should call the underlying
functions. Finally, we need to consider how to choose bootp or
dhcp. You hardcode bootp, but I expect that someone would complain of
why he can't use dhcp instead. I haven't considered this very much
yet.
Okuji
