Hi Mr. OKUJI Yoshinori !
First of all, thanks for the prompt answer, I hope you get my mail,
although I write from my office, not from my home, where I am
registered.
OKUJI Yoshinori wrote:
>> BTW, I must mention several things. First of all, please write
>> ChangeLog entries for your changes. The convention is documented in
>> the GNU Coding Standards. In principle, you can "mimic" the existing
>> entries. Second, you should comply with the GNU C style. This is also
>> documented in the standards. Third, why do you create another buffer
>> for the configuration file name? Can't you just use CONFIG_FILE?
>> Fourth, it is not very good to call builtin commands directly, since
>> GRUB sometimes assumes that some initialization code is done before
>> any builtin command is called. Instead, you should call the underlying
>> functions. Finally, we need to consider how to choose bootp or
>> dhcp. You hardcode bootp, but I expect that someone would complain of
>> why he can't use dhcp instead. I haven't considered this very much
>> yet.
(you = OKUJI Yoshinori, in the rest of the text)
Sorry, I have not written any entry in the ChangeLog, although
I normally do. In this case, as I cannot check in directly, I thought
you inspect the code and so I thought, I should not do entires in
the ChangeLog, but in future I will.
DHCP versus BOOTP:
I saw in the builtin.c that dhcp_func() calls bootp() as bootp_func()
does. As DHCP is compatible downwards, the BOOTP call seems to work
on DHCP environment. I have not found any special DHCP call, yet !
But I see, that in the use of such a tag as 'T99' there could be a
problem in use with DHCP. But see my code as first working step into
the diskless GRUB operation. Of course there are some steps to
discuss, but I think it could be a good idea to have the first step
implemented, if it does not break special design issues - and I don't
think, this implementation does.
To use the 'config_file' buffer is a good idea. This was a relict of the
first test implementation. I will change this.
You said, I do not comply with the GNU C style ? Can you give some (or
one)
example. The only problem I know is the position of '{' and '}', as
I have at home our C-style setup of our company. Do you mean this ?
Or is there else a problem ?
Ok, I will send you a second 'diff' if you are interested !
Please reply !
With friendly regards
Christoph Plattner
----------------------------------------------------------------------------
company: [EMAIL PROTECTED]
private: [EMAIL PROTECTED]
