On 22 November 2013 23:53, Reuben Thomas <[email protected]> wrote: > After sending many useful patches in the last few months, I'm delighted to > announce that Sami Kerola has accepted my invitation to become a hello > maintainer.
Hi Reuben, Thank you for asking me to co-maintain this little, but significant project. The message body indirectly hints that the six patches I sent couple days ago are reviewed, and ready to be merged. That said perhaps GNU Hello could formalize patching process --- >From 93e107f5c1bff5ec1548edb8144ea3c8d9fd003e Mon Sep 17 00:00:00 2001 From: Sami Kerola <[email protected]> Date: Sat, 23 Nov 2013 11:58:38 +0000 Subject: [PATCH] document patching process Organization: lastminute.com * README: add patching process segment --- README | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/README b/README index c2740ea..808413b 100644 --- a/README +++ b/README @@ -41,6 +41,22 @@ Bug reports: - unusual options you gave to configure, if any (see config.status). - anything else that you think would be helpful. +Patching process: +- All changes must be sent to mailing list. +- Changes are reviewed by maintainers. +- Maintainer does not review own changes. + * In case of single maintainer, or unresponsive co-maintainer, mailing + list subscribers does the review. +- Review means either a patch approval, comments to author, or a reject. + * Approved patches are taken to upstream git. + * Commented patches will require work before they can be approved. + Comments can be untechnical, such as a change author must submit a + copyright assignment to FSF. + * Authors are encouraged to discontinue work with rejected changes, as + the reject is permanent. +- Maintainers keep track of rejected changes so that developers can avoid + proposing the same in future. + Patches are most welcome; if possible, please make them in git-am format, and include a suitable commit message. -- 1.8.4.2 -- Sami Kerola http://www.iki.fi/kerolasa/
