On 31 December 2013 19:57, Reuben Thomas <[email protected]> wrote:
> On 30 December 2013 11:58, Sami Kerola <[email protected]> wrote:
>> diff --git a/src/hello.c b/src/hello.c
>> #include "progname.h"
>> +#include "progname.h"
>
> You end up with two includes of progname.h here!
Good catch. Fixed in my repo.
>> +/* The official name of this program (e.g., no `g' prefix). */
>> +#define PROGRAM_NAME "hello"
>
> Since in our case it's the same as the package name, can't you use that
> here, and avoid duplicating the string "hello"?
I have feeling that might give wrong impression as an example.
>> +#define AUTHORS \
>> + proper_name ("The King"), \
>> + proper_name ("others")
>
> This looks bizarre. Is "The King" a known joke in hello? I can only find the
> reference in AUTHORS. If we can find a better original author, can we use
> that, and if not, maybe just leave AUTHORS blank (however best one does
> that)?
That was one of the more difficult considerations I had. The King
seems feels more correct than listing all people from AUTHORS file,
git history, etc. I did think writing Brian Kernighan & Dennish
Ritchie, but quite frankly they only invented The Hello algorithm and
have about nothing to do with the GNU Hello. Perhaps it would be more
appropriate to write
#define AUTHORS \
proper_name ("Original Author"),
proper_name ("Second Major Contributor"),
proper_name ("Firstname Lastname")
--
Sami Kerola
http://www.iki.fi/kerolasa/
