> > * add an explicit <br> before outputting a <pre> tag.
> [snip]
> Please explain why is this needed. There's a lot of obscure
> undocumented behavior in the gray area between <br> and <pre> (e.g.,
> see the comment right where you added <br>), so we'd better have a
> good reason for such changes.
ok, i suppose the real problem is that if you have the following in a
texinfo document:
some text in a normal paragraph.
@format
a block that should go inside a pre element
@end format
the html output does not contain a <p> tag even though there is a
double-space in the texinfo input. putting a br was a quick fix that
is almost correct. i'm not really sure how explicit paragraphs (<p>
tags) are produced with makeinfo --html.
> Why did you call get_xref_token with a non-zero argument? All macros
> were already expanded by the call which returns name_arg, see above,
> so doing it again here is redundant.
i didnt realize that get_xref_token expanded all macros in all
arguments, i made that call under the impression that only the macros
in the first argument were expanded.
> I don't think sprintf is good enough: name_arg and ext_arg could have
> special commands like @@, @value, etc. You need to expand them.
> add_word_args that you use to output fullname doesn't do the
> expansion; you need to use execute_string instead. Also, I think that
> special characters in fullname should be HTML-escaped (you can use
> e.g. escape_string for that).
ok, thanks. i'll resubmit.
