Am Sonntag, 28. September 2014, 01:00:40 schrieb Darshit Shah: > >patch version #3 is attached > > Hi Tim, > > I just wanted to point out that there is a blocking issue with this patch. > It eliminates the ability for the user to execute single tests directly. I > can run `make check` without much issues but I cannot execute a single test > by directly invoking it. The $src_topdir variable isn't being set correctly > in that case. > > In my opinion, that is an extremely important feature when debugging Wget > with a single failing test, or when writing a new test.
Hi Darshit, that's a good point. A make check -j4 just takes a few seconds on my machine, so I wouldn't mind. But yes, there might me much slower machines... Some tests require to have $top_srcdir in the old test suite as well (e.g.Test-proxied-https-auth.px). How do you execute these directly ? I don't have the sources here, I'll take a closer look at it on Monday. Tim
signature.asc
Description: This is a digitally signed message part.
