On 09/30, Tim Rühsen wrote:
Here we go with a new version of the patch, fixing some issues: - make distcheck works again - the tests can be started separate in tests/ directory (also fixed Test- proxied-https-auth.px finding certs without $top_srcdir)Any comments ? Tim
--- end quoted text --- Hi Tim,I was just going through your patch. Could you please add the *.trs and *.log entries to the .gitignore file? They would be listed under the Wildcards.
About the fix for Test-proxied-https.px, I came across the following guideline in the Automake Tests manual:
Test programs that need data files should look for them in srcdir (which is both a make variable and an environment variable made available to the tests), so that they work when building in a separate directory (see Build Directories in The Autoconf Manual), and in particular for the distcheck rule (see Checking the Distribution).I've been implementing a fix for testenv/ using abs_top_srcdir, but it seems we should be using $srcdir, maybe you can fix that?
Also, the patch was generated against a slightly older git history, which is why it doesn't apply cleanly and fails on ChangeLog. Maybe you could run a git pull and then rebase your patch off the latest commit?
I have fixed the issues with make distcheck in testenv/ and will push the patch right after yours.
-- Thanking You, Darshit Shah
pgphQl5MHRQ_g.pgp
Description: PGP signature
