Hi Hubert, A bit of feedback here.
On 05/12/2015 10:05 PM, Hubert Tarasiuk wrote:
I would be very pleased if you could review my code and maybe point out some mistakes or any other comments/suggestions. Maybe you have ideas about some improvements to it?
First of all, please correct the typo at gethttp: Ommiting --> Omitting And second, I'm not really sure whether --condget is the best name for the switch. Requests that include any of If-Unmodified-Since, If-Match, If-None-Match, or If-Range header fields are also "conditional GETs" as well. We might want to implement one of those in the future and we'd be forced to choose a name which could easily be inconsistent/confusing with --condget. Or maybe we won't. But we don't know that now, so I think it's better to choose a switch more specific to the fact that an If-Modified-Since header will be sent so as to avoid confusion. -- Regards, - AJ
