Mark Kettenis wrote: > > From: "Ted Unangst" <[email protected]> > > Date: Wed, 09 Dec 2015 06:49:42 -0500 > > > > Thinkpad X1 2015 (broadwell). This is a recent regression, though I'm not > > sure > > when it was introduced. I have lidsuspend=0. When I close the lid and open > > it > > again, the screen comes back at 100% brightness. As in, far too bright. > > > > Previously, the screen would always open back up at the same brightness > > level > > I closed it at. kettenis mentioned that the keyboard brightness keys work > > (they do) but that's a recent addition. For many months, they did not. I > > wonder if the changes are correlated. > > They probably are. And probably the weird behaviour of the brightness > keys is related as well. See my rants about ACPI being fucked because > we claim to support both Windows 7 and Windows 8. My suggestion would > be to comment out most of the Windows versions in the "aml_valid_osi" > array and see how the behaviour changes if you only enable the > "Windows 2012", "Windows 2009" or "Windows 2006" entry.
It took a while to get around to it, but I'm now running with the diff below and things seem much more sensible. The brightness controls still work, but things don't reset every time I add or remove power. Index: acpi/dsdt.c =================================================================== RCS file: /cvs/src/sys/dev/acpi/dsdt.c,v retrieving revision 1.218 diff -u -p -r1.218 dsdt.c --- acpi/dsdt.c 20 Aug 2015 20:50:10 -0000 1.218 +++ acpi/dsdt.c 9 Dec 2015 14:06:50 -0000 @@ -1,4 +1,4 @@ -/* $OpenBSD: dsdt.c,v 1.218 2015/08/20 20:50:10 kettenis Exp $ */ +/* $OpenBSD: dsdt.c,v 1.217 2015/05/04 10:42:06 jmatthew Exp $ */ /* * Copyright (c) 2005 Jordan Hargrave <[email protected]> * @@ -1476,18 +1476,7 @@ struct aml_defval { * We return True for Windows to fake out nasty bad AML */ char *aml_valid_osi[] = { - "Windows 2000", - "Windows 2001", - "Windows 2001.1", - "Windows 2001 SP0", - "Windows 2001 SP1", - "Windows 2001 SP2", - "Windows 2001 SP3", - "Windows 2001 SP4", - "Windows 2006", "Windows 2009", - "Windows 2012", - "Windows 2013", NULL };
