The DISABLE_INTREE_EC flag is designed to control whether the Elliptic Curve
support in the
JDK source tree is skipped during a build. It is used to avoid the duplication
of EC libraries on
platforms where an EC library is already present.
In the old build it was a build option. In the new build it appears to be
controlled by the presence
of a directory. That is incorrect as the directory is always present. The
behaviour differs from the old build.
On 14 Mar 2013, at 10:03, David Holmes wrote:
> On 14/03/2013 3:12 PM, David Holmes wrote:
>> Note that this isn't changing any functionality simply exposing an
>> existing make variable at configure time.
>
> Correction. I misunderstood what was being done here. This forcibly
> set/clears the make variable based solely on the existence of a directory:
>
> test -d "${SRC_ROOT}/jdk/src/share/native/sun/security/ec/impl"
>
> It doesn't expose a configure option for this. This may be perfectly fine but
> the person who wrote the original TODO comment needs to verify that.
>
> David
>
>> David
>>
>> On 14/03/2013 2:38 PM, Brad Wetmore wrote:
>>> CC'ing security-dev.
>>>
>>> Vinnie,
>>>
>>> As owner of ECC, you should probably look at this.
>>>
>>> Brad
>>>
>>>
>>> On 3/13/2013 7:02 PM, David Holmes wrote:
>>>> On 14/03/2013 6:09 AM, Omair Majid wrote:
>>>>> Hi,
>>>>>
>>>>> jdk/makefiles/CompileNativeLibraries.gmk has a little note:
>>>>>
>>>>> TODO Set DISABLE_INTREE_EC in configure if
>>>>> src/share/native/sun/security/ec/impl is not present
>>>>>
>>>>> The webrev at http://cr.openjdk.java.net/~omajid/webrevs/intree-ec/00/
>>>>> implements this. Does this look okay for jdk8/build ? Can I get a bug
>>>>> id?
>>>>
>>>> Bug ID: 8010030
>>>>
>>>> I think it is more consistent to set the variable to yes/no and change:
>>>>
>>>> ifndef DISABLE_INTREE_EC
>>>>
>>>> to
>>>>
>>>> ifeq ($DISABLE_INTREE_EC), yes)
>>>>
>>>> Thanks,
>>>> David
>>>>
>>>>
>>>>
>>>>> Thanks,
>>>>> Omair
>>>>>
