You're correct Omar. That target directory is not always present as I had indicated below. The new and old builds are indeed consistent in the way they handle that.
Thanks. On 14 Mar 2013, at 19:50, Omair Majid wrote: > On 03/14/2013 03:14 PM, Vincent Ryan wrote: >> The DISABLE_INTREE_EC flag is designed to control whether the Elliptic Curve >> support in the >> JDK source tree is skipped during a build. It is used to avoid the >> duplication of EC libraries on >> platforms where an EC library is already present. >> >> In the old build it was a build option. In the new build it appears to be >> controlled by the presence >> of a directory. That is incorrect as the directory is always present. The >> behaviour differs from the old build. > > FWIW, the current new-build and the current old-build both allow you to > specify 'make DISABLE_INTREE_EC=yes' and do the right thing. > > However, currently there is no way to say this using configure. The > patch I posted makes configure automatically set DISABLE_INTREE_EC=yes > if the directory is not found. The directory is always present in > OpenJDK8. However, some Linux distributions prefer to build with ECC > disabled due to legal reasons [1], and will remove the directory when > they create the OpenJDK8 source tarball. Where they had to delete the > directory _and_ set DISABLE_INTREE_EC before, with this patch they just > have to delete the directory. > > If you would like me to add a configure option to control this as well, > then I will be happy to add that too. May I do that as a separate patch? > > Thanks, > Omair > > [1] http://en.wikipedia.org/wiki/ECC_patents > > -- > PGP Key: 66484681 (http://pgp.mit.edu/) > Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681
