On 2013-03-14 20:37, Omair Majid wrote:
Andrew Hughes wrote the original changeset in the old build system [1]
and I believe this is exactly what he wanted out of the changeset. I am
CC'ing Erik, who wrote the TODO [2] so he can clarify what he meant.
I didn't actually create that comment in the first place, I just
committed it as part of a big move of changes from the build-infra
repos, where the work was done in small increments. Looking at this, I'm
suspecting the comment was added due to this comment in
jdk/make/sun/security/ec/Makefile:
#
# Some licensees do not get the native ECC sources, but we still need to
# be able to build "all" for them. Check here to see if the sources are
# available. If not, then skip them.
#
A usecase probably not that interesting to the OpenJDK community, but as
Omair points out, it still applies, so I think this is a good idea.
Adding a configure option for it would be nice too, but I don't see it
as a requirement for this fix. I like the last suggestion with a clear
yes/no with no double negatives, it looks ok.
And as David pointed out, please notify me and Tim Bell when you push
this so we may have a chance at keeping the Oracle internal configure
script up to date. Also please avoid pushing on a Wednesday as that's
when the integration to master happens and the likelihood of bad timing
increases. I don't like this complication any more than any of you, but
for the time being, that's the way it is.
/Erik
