On 2014-02-06 14:23, Alan Bateman wrote:
On 06/02/2014 12:23, Erik Joelsson wrote:Looks good to me. Only a minor comment on indentation in jdk/makeGenerateClasses.gmk. We try to keep block indentation at 2 spaces and continuation indentation at 4 spaces, so line 96 should only be 2 spaces.Thanks Erik. I'll fix the indentation in GenerateClasses.gmk (and I assume CompileJavaClasses.gmk L48 too) before pushing this.
Right, there too, thanks! /Erik
