On 6 feb 2014, at 13:06, Alan Bateman <alan.bate...@oracle.com> wrote: > > This is the first time that I've added a configure option to the build so I > may need help getting this right. The patch that I'm currently using is here: > > http://cr.openjdk.java.net/~alanb/8033366/webrev/
It looks basically good. Some comments: In spec.gmk.in: +RMICONNECTOR_IIOP=@RMICONNECTOR_IIOP@ Please use := as = has a special meaning in make (late evaluation). Simple assignment is :=. In jdk-options.m4: Please add a set of AC_MSG_CHECKING/RESULT for presenting the value of the flag. You can find examples in the code. Otherwise it looks fine. /Magnus
