On 07/02/2014 01:06, Magnus Ihse Bursie wrote:
It looks basically good. Some comments:
In spec.gmk.in:
+RMICONNECTOR_IIOP=@RMICONNECTOR_IIOP@
Please use := as = has a special meaning in make (late evaluation). Simple
assignment is :=.
In jdk-options.m4:
Please add a set of AC_MSG_CHECKING/RESULT for presenting the value of the
flag. You can find examples in the code.
Otherwise it looks fine.
This was pushed yesterday so it will require a new issue to update it.
On the simple assignment vs. late evaluation then it looks like there is
a mix in spec.gmk.in and I assume that others should be changed too
(just wondering if this is something that you or Erik should take).
I can add AC_MSG_CHECKING/AC_MSG_RESULT, not sure how I missed those. It
may be missed from others too.
-Alan.
