Compatible module refactoring in action! Looks good, one comment:
test/jdk/javax/transaction/xa/testng/JavaSqlModuleDriver.java This is not a valid Java source file can you merge the jtreg meta data into XAExceptionTests instead? Paul. > On Feb 28, 2018, at 10:25 AM, Lance Andersen <lance.ander...@oracle.com> > wrote: > > Hi all, > > This RFR request moves the javax.transaction.xa package out of the java.sql > module and into its own module java.transaction.xa. One of the motivators > for this change is due to the fact JSR 907 1.3 MR indicated that the > javax.transaction.xa package will be subsumed by Java SE. > > There should be no compatibility issues with this change. Any module that > `requires java.sql` will continue to have access to the public classes in the > javax.transaction.xa package at both compile-time and run-time. > > > The CSR has been approved > > The webrev can be found at: > http://cr.openjdk.java.net/~lancea/8197533/webrev.00/ > > Best > Lance > <http://oracle.com/us/design/oracle-email-sig-198324.gif> > <http://oracle.com/us/design/oracle-email-sig-198324.gif> > <http://oracle.com/us/design/oracle-email-sig-198324.gif> > <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| > Principal Member of Technical Staff | +1.781.442.2037 > Oracle Java Engineering > 1 Network Drive > Burlington, MA 01803 > lance.ander...@oracle.com <mailto:lance.ander...@oracle.com> > > >
