> On Feb 28, 2018, at 1:22 PM, Lance Andersen <lance.ander...@oracle.com> wrote: > >> >> On Feb 28, 2018, at 2:20 PM, Lance Andersen <lance.ander...@oracle.com >> <mailto:lance.ander...@oracle.com>> wrote: >> >> Hi Paul, >> >> Thank you for the review. >>> On Feb 28, 2018, at 1:40 PM, Paul Sandoz <paul.san...@oracle.com >>> <mailto:paul.san...@oracle.com>> wrote: >>> >>> Compatible module refactoring in action! >>> >>> Looks good, one comment: >>> >>> test/jdk/javax/transaction/xa/testng/JavaSqlModuleDriver.java >>> >>> This is not a valid Java source file can you merge the jtreg meta data into >>> XAExceptionTests instead? >> >> As we discussed offline, I will change the above file and Driver.java. I >> naively assumed this was OK as the change to add Driver.java was made after >> I had originally added these tests in 2015. > > http://cr.openjdk.java.net/~lancea/8197533/webrev.01/ > <http://cr.openjdk.java.net/~lancea/8197533/webrev.01/> has the updated tests
+1, i second Joe’s request to update package-info.java while we are opportunistically cleaning this area up. Paul.
