On 08/20/20 17:08 pm, Andrew Haley wrote: >> >> I meant move the test itself - entry() and asm_check() in >> assembler_aarch64.cpp - under test/hotspot/gtest. The generator would >> move with it. > > Hmm. I'm still not sure how this would work. Let's see the patch and > we can talk about it. It still sounds to me rather like pointlessly > moving the furniture around.
http://cr.openjdk.java.net/~ngasson/asmtest/webrev.0/ Then you'd run it with make exploded-test TEST="gtest:AssemblerAArch64" The downside is that it won't run on every startup of a debug build, but it will run in the tier1 tests, including for release builds, which arguably gives more coverage. It looks a lot tidier to me, but that's clearly subjective. -- Thanks, Nick
