On 2020-08-20 12:38, Andrew Dinn wrote:
On 20/08/2020 11:14, Magnus Ihse Bursie wrote:
On 2020-08-20 11:40, Nick Gasson wrote:
http://cr.openjdk.java.net/~ngasson/asmtest/webrev.0/
Then you'd run it with
make exploded-test TEST="gtest:AssemblerAArch64"
The downside is that it won't run on every startup of a debug build, but
it will run in the tier1 tests, including for release builds, which
arguably gives more coverage. It looks a lot tidier to me, but that's
clearly subjective.
FWIW, it definitely looks tidier to me too.
Well, perhaps this check ought to be done as a standalone test rather
than as debug build validation. I don't really have any deep commitment
either way. However, if we do proceed with this I think it ought to be
in a separate follow-up patch and with its own JIRA. It should not stop
Ningsheng's SVE patch going in as is since that merely corrects the
status quo to allow for SVE instructions.
Yes, I fully agree, and never meant to imply anything else.
/Magnus
regards,
Andrew Dinn
-----------
Red Hat Distinguished Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill
