On Mon, 7 Mar 2022 19:53:34 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> make/autoconf/jdk-version.m4 line 129: >> >>> 127: AC_MSG_ERROR([--with-vendor-url must have a value]) >>> 128: elif test "x$with_vendor_url" = xno; then >>> 129: AC_MSG_WARN([--without-vendor-url is the same as not passing >>> --with-vendor-url to begin with]) >> >> Same as with vendor. > > I think this, even more, makes it clear that `--without-vendor-url` can´t > possible be meant to be interpreted as "use https://openjdk.java.net/";. > > Basically, I think what I'm arguing for is that we can fold this check into > the "yes" check -- both `--with-vendor-url` (with no given value) and > `--without-vendor-url` are invalid. So something like this: > > > if test "x$with_vendor_url" = xyes || test "x$with_vendor_url" = xno; then > AC_MSG_ERROR([--with-vendor-url must have a value]) > elif... ... and this goes for all the changes in the PR. ------------- PR: https://git.openjdk.java.net/jdk/pull/7713
