On Mon, 11 Apr 2022 16:53:41 GMT, Erik Joelsson <er...@openjdk.org> wrote:

>> Andrew Leonard has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   8284661: Reproducible assembly builds without relative linking
>>   
>>   Signed-off-by: Andrew Leonard <anleo...@redhat.com>
>
> test/jdk/build/AbsPathsInImage.java line 167:
> 
>> 165:                 if (Files.isSymbolicLink(file)) {
>> 166:                     return super.visitFile(file, attrs);
>> 167:                 } else if (fileName.endsWith(".pdb")) {
> 
> The .debuginfo suffix has at least historically been used on more OSes than 
> just Linux. I think we should only include .debuginfo files in this test if 
> the OS is also Linux.

@erikj79 As far as I can see only AIX is the exception of not being Linux and 
using .debuginfo suffix, are there others?
I am currently testing AIX, so I will see if it passes, as you say, I would 
have my doubts it will!

-------------

PR: https://git.openjdk.java.net/jdk/pull/8177

Reply via email to