On Mon, 11 Apr 2022 16:17:08 GMT, Andrew Leonard <aleon...@openjdk.org> wrote:
>> Andrew Leonard has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8284661: Reproducible assembly builds without relative linking >> >> Signed-off-by: Andrew Leonard <anleo...@redhat.com> > > @magicus @mkartashev For your reviews please. > I'm also currently running a full platform build at Adoptium, so as to ensure > validation on all Linux flavors > (https://ci.adoptopenjdk.net/job/build-scripts/job/openjdk19-pipeline/88/parameters/), > and plan to run AbsPathsInImage against them all. > > Hi @andrew-m-leonard, I am currently working on moving SafeFetch to static > > assembly: > > #7865 > > Would your change affect that, especially the ability to export > > inner-function labels as jump-back-points? > > hi @tstuefe Thomas, this is only requiring .file directives in linux .S > files, which will mean your PR will require the line: > > ``` > .file ASSEMBLY_SRC_FILE > ``` > > assuming they don't already have a .file... but I don't think it should > affect anything else you're doing. > Thanks, I'll try it out. > > Also, riscv, ppcle and s390 are missing, why not do it on all platforms? > > Which .S files am I missing for these flavors of Linux? Oh right, my patch introduces the first S files on those platforms, there are none today. ------------- PR: https://git.openjdk.java.net/jdk/pull/8177
