On Wed, 28 Sep 2022 02:06:44 GMT, David Holmes <[email protected]> wrote:
>> There are number of places where misleading-indentation is reported by GCC.
>> Currently, the warning is disabled for the entirety of Hotspot, which is not
>> good.
>>
>> C1 does an unusual style here. Changing it globally would touch a lot of
>> lines. Instead of doing that, I fit the existing style while also resolving
>> the warnings. Note this actually solves a bug in `lir_alloc_array`, where
>> `do_temp` are called without a check.
>>
>> Build-tested this with product of:
>> - GCC 10
>> - {i686, x86_64, aarch64, powerpc64le, s390x, armhf, riscv64}
>> - {server, zero}
>> - {release, fastdebug}
>>
>> Linux x86_64 fastdebug `tier1` is fine.
>
> src/hotspot/share/classfile/javaClasses.cpp line 3926:
>
>> 3924: if (k == NULL) return NULL;
>> 3925: InstanceKlass* ik = InstanceKlass::cast(k);
>> 3926: if (!ik->is_initialized()) ik->initialize(CHECK_NULL);
>
> That's actually a bug!
How is this a bu... ah. Oh! The second statement from `CHECK_NULL` is
effectively out of `if (!ik->is_initialized())` block!
-------------
PR: https://git.openjdk.org/jdk/pull/10444
