On 9/28/22 06:28, Baesken, Matthias wrote:

Hello, I noticed still a few references to hg in current openjdk subtree make, I wonder should we remove / replace  them ?

Some of those :

make/autoconf/basic.m4

AC_MSG_ERROR([Bad file permissions on src files. This is usually caused by cloning the repositories with a non cygwin hg in a directory not created in cygwin.])

Is this still an issue  at all with git ?

I'm not sure if this is reproducible with Git on Windows/Cygwin. The reference to hg should be fixed though.

make/autoconf/spec.gmk.in

772 HG:=@HG@

make/autoconf/basic_tools.m4

345 UTIL_LOOKUP_PROGS(HG, hg)

Those are certainly not needed anymore.

make/scripts/update_copyright_year.sh has also quite a few references to hg, but I am not very familiar with the script.

I would leave this script alone unless you intend to really fix it. I never used it myself, but having it around for reference may be best for now.

/Erik

Reply via email to