On Thu, 27 Oct 2022 13:38:04 GMT, Julian Waters <jwat...@openjdk.org> wrote:

> Strip currently has its flags set by guessing based on the OS, it would be 
> more appropriate to instead set them based on properly checking the strip 
> binary instead of speculating what the correct flags are based on the 
> compiler and OS.

This looks good assuming you have verified that it works on all the affected 
platforms.

-------------

Marked as reviewed by erikj (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10882

Reply via email to