> Strip currently has its flags set by guessing based on the OS, it would be > more appropriate to instead set them based on properly checking the strip > binary instead of speculating what the correct flags are based on the > compiler and OS.
Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 17 additional commits since the last revision: - Merge branch 'openjdk:master' into patch-1 - Merge branch 'openjdk:master' into patch-1 - Comment can be made more accurate - Merge branch 'openjdk:master' into patch-1 - Merge branch 'openjdk:master' into patch-1 - Merge branch 'openjdk:master' into patch-1 - Add more documentation - Replace with the actual new check - Little documentation doesn't hurt - Prepare for actual changes - ... and 7 more: https://git.openjdk.org/jdk/compare/c45090f7...5f97c5c7 ------------- Changes: - all: https://git.openjdk.org/jdk/pull/10882/files - new: https://git.openjdk.org/jdk/pull/10882/files/df46df9d..5f97c5c7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=10882&range=05 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10882&range=04-05 Stats: 2029 lines in 70 files changed: 1414 ins; 247 del; 368 mod Patch: https://git.openjdk.org/jdk/pull/10882.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10882/head:pull/10882 PR: https://git.openjdk.org/jdk/pull/10882
