> Strip currently has its flags set by guessing based on the OS, it would be > more appropriate to instead set them based on properly checking the strip > binary instead of speculating what the correct flags are based on the > compiler and OS.
Julian Waters has updated the pull request incrementally with one additional commit since the last revision: Comment can be made more accurate ------------- Changes: - all: https://git.openjdk.org/jdk/pull/10882/files - new: https://git.openjdk.org/jdk/pull/10882/files/a940c741..d831ca59 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=10882&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10882&range=02-03 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/10882.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10882/head:pull/10882 PR: https://git.openjdk.org/jdk/pull/10882
