On Wed, 11 Jan 2023 14:09:23 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> This seems to do the right thing without summarizing the number of object >> files compiled for the tests. > > I'm sorry, but I don't think this is the right solution here. I agree that > the log level needs to be altered in some way when compiling the tests, as > there are so many of them, but this removes logging at the default level for > all native targets. I also think it's inconsistent if the "Creating ..." log > message is on info while the "Updating ..." of the same thing is still on > warn. > > I think a better solution would be to give SetupNativeCompilation a parameter > or two that controls log level, and that the SetupTestCompilation macro could > use that to lower the level for test compilations, while probably also adding > a meta log message for all the tests it's building to replace the individual > log messages on level warn. @erikj79 @magicus I added a parameter but not the meta log message for the tests. It seems to work. ------------- PR: https://git.openjdk.org/jdk/pull/11930
