On Thu, 12 Jan 2023 18:01:50 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> This change makes native output files be only printed when building with >> LOG=info, to make the build not have so many pages of output. >> Tested with GHA and locally (tbd) > > Coleen Phillimore has updated the pull request incrementally with one > additional commit since the last revision: > > This seems to do the right thing without summarizing the number of object > files compiled for the tests. Hm. I fully agree on the problem description, but not entirely sure about this solution. In contrast with Erik, I was more thinking along the lines that the decision to be more quiet could be made by SetupNativeCompilation itself, based on the number of files it compiled. So if it only compiled a single c file into a single dll, then it should be quiet. With "meta message", I think Erik means that if all tests are suddenly being quiet, we should compensate by printing a more general high-level message like "Building NN native tests". ------------- PR: https://git.openjdk.org/jdk/pull/11930
