Hi, Jonathan Gibbons, would you mind taking a look at this and approve if this looks good? I wish to get this into JDK 21 before RDP 1 starts.
On Mon, May 22, 2023 at 2:25 AM Per Minborg <[email protected]> wrote: > > On Tue, 16 May 2023 17:16:57 GMT, Chen Liang <[email protected]> wrote: > > >> `@sealedGraph` had a mechanism to render non-sealed classes differently, > >> but it's useless because the graph nodes are not bordered. This patch > >> converts the non-sealed classes to be rendered in italics instead. > >> > >> An example of `ConstantDesc`, which has a sealed hierarchy except > >> `DynamicConstantDesc`: > >> JDK 20: > >>  > >> > >> This patch: > >>  > > > > Chen Liang has updated the pull request with a new target base due to a > > merge or a rebase. The incremental webrev excludes the unrelated changes > > brought in by the merge/rebase. The pull request contains three additional > > commits since the last revision: > > > > - Use an edge and node to indicate non-sealed hierarchy > > - Merge branch 'master' into fix/sealedgraph-nonsealed > > - 8307652: sealed class hierarchy graph doesn't distinguish non-sealed > > classes > > Marked as reviewed by pminborg (Committer). > > ------------- > > PR Review: https://git.openjdk.org/jdk/pull/13877#pullrequestreview-1435944754
