On Sun, 2 Jun 2024 02:49:47 GMT, SendaoYan <s...@openjdk.org> wrote: > Hi all, > This PR try to fix linux x86_32 configure fail with `--with-hsdis=binutils > --with-binutils-src`. The libiberty.a locates in > `build/linux-x86-server-fastdebug/configure-support/binutils-install/lib32` > on linux ubuntu20. The change has been verified, the risk is low. > > Additional testing: > > - [x] linux x86_32 centos7 configure > - [x] linux x86_64 centos7 configure > - [x] linux x86_32 ubuntu20 configure > - [x] linux x86_64 ubuntu20 configure > > > [configure-linux-centos7-x86_32.log](https://github.com/user-attachments/files/15523974/configure-linux-centos7-x86_32.log) > [configure-linux-centos7-x86_64.log](https://github.com/user-attachments/files/15523976/configure-linux-centos7-x86_64.log) > [configure-ubuntu20-x86_32.log](https://github.com/user-attachments/files/15523977/configure-ubuntu20-x86_32.log) > [configure-ubuntu20-x86_64.log](https://github.com/user-attachments/files/15523978/configure-ubuntu20-x86_64.log)
Don't forget about me! :) make/autoconf/lib-hsdis.m4 line 274: > 272: HSDIS_CFLAGS="-DLIBARCH_$OPENJDK_TARGET_CPU_LEGACY_LIB > -I$BINUTILS_INSTALL_DIR/include" > 273: > 274: # libiberty ignores --libdir and may be installed in > $BINUTILS_INSTALL_DIR/lib, $BINUTILS_INSTALL_DIR/lib32 or > $BINUTILS_INSTALL_DIR/lib64 Nit: "or $BINUTILS_INSTALL_DIR/lib64" should probably be on the new line in this comment ------------- Marked as reviewed by jwaters (Committer). PR Review: https://git.openjdk.org/jdk/pull/19511#pullrequestreview-2093236451 PR Review Comment: https://git.openjdk.org/jdk/pull/19511#discussion_r1624067867
