On Mon, 3 Jun 2024 09:16:36 GMT, SendaoYan <s...@openjdk.org> wrote: >> Hi all, >> This PR try to fix linux x86_32 configure fail with `--with-hsdis=binutils >> --with-binutils-src`. The libiberty.a locates in >> `build/linux-x86-server-fastdebug/configure-support/binutils-install/lib32` >> on linux ubuntu20. The change has been verified, the risk is low. >> >> Additional testing: >> >> - [x] linux x86_32 centos7 configure >> - [x] linux x86_64 centos7 configure >> - [x] linux x86_32 ubuntu20 configure >> - [x] linux x86_64 ubuntu20 configure >> >> >> [configure-linux-centos7-x86_32.log](https://github.com/user-attachments/files/15523974/configure-linux-centos7-x86_32.log) >> [configure-linux-centos7-x86_64.log](https://github.com/user-attachments/files/15523976/configure-linux-centos7-x86_64.log) >> [configure-ubuntu20-x86_32.log](https://github.com/user-attachments/files/15523977/configure-ubuntu20-x86_32.log) >> [configure-ubuntu20-x86_64.log](https://github.com/user-attachments/files/15523978/configure-ubuntu20-x86_64.log) > > SendaoYan has updated the pull request incrementally with one additional > commit since the last revision: > > "or $BINUTILS_INSTALL_DIR/lib64" should probably be on the new line in this > comment
Marked as reviewed by ihse (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/19511#pullrequestreview-2093377467
