On Mon, 3 Jun 2024 08:59:50 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> SendaoYan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> "or $BINUTILS_INSTALL_DIR/lib64" should probably be on the new line in >> this comment > > make/autoconf/lib-hsdis.m4 line 274: > >> 272: HSDIS_CFLAGS="-DLIBARCH_$OPENJDK_TARGET_CPU_LEGACY_LIB >> -I$BINUTILS_INSTALL_DIR/include" >> 273: >> 274: # libiberty ignores --libdir and may be installed in >> $BINUTILS_INSTALL_DIR/lib, $BINUTILS_INSTALL_DIR/lib32 or >> $BINUTILS_INSTALL_DIR/lib64 > > Nit: "or $BINUTILS_INSTALL_DIR/lib64" should probably be on the new line in > this comment Thanks for the suggest, the comment line has been updated. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19511#discussion_r1624087661
