On Wed, 2 Oct 2024 19:03:09 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
>> GHA conveniently collects hs_errs from the test job runs. However, when we >> have a failure during the build, e.g. javac, CDS, jmod, jlink crashes the >> VM, we don't have these automatically collected. This is annoying when VM >> crashes on a particular platform, and not on others. >> >> We can add the hooks for these as well. This PR adapts what we already have >> for test result collectors here: >> https://github.com/openjdk/jdk/blob/master/.github/scripts/gen-test-results.sh >> >> I added a deliberate failure point in CDS to demonstrate how it would look >> like in test summary. > > Aleksey Shipilev has updated the pull request incrementally with one > additional commit since the last revision: > > Gaaaaaaah .github/scripts/gen-build-failure-report.sh line 69: > 67: ) >> $GITHUB_STEP_SUMMARY > 68: > 69: # With large hs_errs, the summary can easily exceed 1024 kB, the limit > set by Github This code duplication is nagging me a bit. Do you think it would make sense to extract it to a separate helper in `.github/scripts`? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21308#discussion_r1791846561
