On Wed, 9 Oct 2024 08:13:32 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
>> GHA conveniently collects hs_errs from the test job runs. However, when we >> have a failure during the build, e.g. javac, CDS, jmod, jlink crashes the >> VM, we don't have these automatically collected. This is annoying when VM >> crashes on a particular platform, and not on others. >> >> We can add the hooks for these as well. This PR adapts what we already have >> for test result collectors here: >> https://github.com/openjdk/jdk/blob/master/.github/scripts/gen-test-results.sh >> >> I added a deliberate failure point in CDS to demonstrate how it would look >> like in test summary. > > Aleksey Shipilev has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains seven additional > commits since the last revision: > > - Yank the cord > - Newline changes > - Merge branch 'master' into JDK-8341424-gha-collect-build-hs-err > - Attempt to share truncation code > - Gaaaaaaah > - Stylistic touchups > - Fix Thanks! ------------- PR Comment: https://git.openjdk.org/jdk/pull/21308#issuecomment-2402900414
