On Wed, 2 Oct 2024 19:03:09 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
>> GHA conveniently collects hs_errs from the test job runs. However, when we >> have a failure during the build, e.g. javac, CDS, jmod, jlink crashes the >> VM, we don't have these automatically collected. This is annoying when VM >> crashes on a particular platform, and not on others. >> >> We can add the hooks for these as well. This PR adapts what we already have >> for test result collectors here: >> https://github.com/openjdk/jdk/blob/master/.github/scripts/gen-test-results.sh >> >> I added a deliberate failure point in CDS to demonstrate how it would look >> like in test summary. > > Aleksey Shipilev has updated the pull request incrementally with one > additional commit since the last revision: > > Gaaaaaaah src/hotspot/share/cds/cdsConfig.cpp line 281: > 279: }; > 280: > 281: assert(false, "GHA TEST FAILURE POINT. REMOVE BEFORE FLIGHT"); // Or > wait for Friday and integrate for extra fun. The generated summaries look fine. Don't forget to remove this. :) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21308#discussion_r1791851049
