On Tue, 4 Mar 2025 17:16:41 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Make END keyword at the same level as the regrex line
>
> make/RunTests.gmk line 546:
>
>> 544: found=1; \
>> 545: } } END \
>> 546: { if (!found) print 0; }' \
>
> From what I can tell, this is the relevant fix, moving the fallback 0 to the
> `END` block. I would suggest reformatting this for better readability.
> Probably something like this. The `END` keyword should be at the same level
> as the regex line matcher above, though the mix of indentation levels here is
> a bit confusing.
> Suggestion:
>
> } \
> } \
> END { if (!found) print 0; }' \
Thanks, END keyword has been change to at the same level as the regrex line
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23904#discussion_r1980549314
