On Tue, 4 Mar 2025 17:17:32 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> SendaoYan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert regex change in if expr > > make/RunTests.gmk line 543: > >> 541: '/YOU HAVE [0-9]+ DISABLED TEST/ { \ >> 542: if (match($$$$0, /YOU HAVE ([0-9]+) DISABLED TEST/, >> arr)) { \ >> 543: print arr[1]; \ > > I can't see how this change is needed. The block after the `/.../` regex will > only be executed for lines matching the regex. You are right, these two line change has been reverted. Thanks. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23904#discussion_r1980555286