On Wed, 5 Mar 2025 02:10:34 GMT, SendaoYan <s...@openjdk.org> wrote:
>> Hi all,
>>
>> This PR fix the makefile bug when there is no gtest 'disable tests' then
>> report syntax error.
>>
>> Before this PR makefile used below command to get the 'disable tests'
>> number, when there is no 'YOU HAVE [0-9]+ DISABLED TEST' string line in
>> gtest result file gtest.txt, this gawk command will not print anything, so
>> shell report syntax error later.
>>
>>
>> gawk '/YOU HAVE [0-9]+ DISABLED TEST/ { if (match($0, /[0-9]+/, arr)) {
>> print arr[0]; found=1; } if (!found) { print 0; } }'
>> build/linux-x86_64-server-release/test-results/gtest_Align_server/gtest.txt
>>
>>
>> After this PR makefile will use below command to get the 'disable tests'
>> number.
>>
>>
>> gawk '/YOU HAVE [0-9]+ DISABLED TEST/ { if (match($0, /[0-9]+/, arr)) {
>> print arr[0]; found=1; } } END { if (!found) print 0; }'
>> build/linux-x86_64-server-release/test-results/gtest_Align_server/gtest.txt
>>
>>
>> Additional testing:
>>
>> - [x] make test TEST=gtest:Align > test-Alian.log, which return 0 disable
>> test
>> - [x] time make test TEST=gtest > test-all.log, which return 15 disable tests
>>
>> [test-all.log](https://github.com/user-attachments/files/19074190/test-all.log)
>> [test-Alian.log](https://github.com/user-attachments/files/19074189/test-Alian.log)
>
> SendaoYan has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert regex change in if expr
Okay, then it's all fine. I misunderstood the code and your patch. Thank you,
and apologies.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23904#issuecomment-2710207110
