On Mon, 10 Mar 2025 18:28:44 GMT, Jiangli Zhou <jian...@openjdk.org> wrote:

>> Please review this PR that excludes `libjsig` from being statically linked 
>> with `static-jdk` `java` launcher by default. Please see details in 
>> https://bugs.openjdk.org/browse/JDK-8351309 description and comments. Thanks
>
> Jiangli Zhou has updated the pull request incrementally with two additional 
> commits since the last revision:
> 
>  - Address magicus' feedback, set `ONLY_EXPORTED := true` for LIBJSIG.
>  - Revert make/StaticLibs.gmk.

Still LGTM. I recommend waiting for approval from @magicus as well.

-------------

Marked as reviewed by manc (Committer).

PR Review: https://git.openjdk.org/jdk/pull/23924#pullrequestreview-2675782966

Reply via email to