On Thu, 13 Mar 2025 13:06:38 GMT, Matthias Baesken <[email protected]> wrote:
>> Seems Wayland is not supported on AIX, so we most likely do not need to
>> build pipewire on AIX and can remove it from the build.
>> Reason is that pipewire updates can break the AIX build, so better avoid it
>> if possible.
>>
>> To check if it works, I move the 'pipewire/include' folder away, and the
>> build still worked on AIX.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last revision:
>
> remove AIX special handling from endian.h
src/java.desktop/unix/native/libawt_xawt/awt/screencast_pipewire.c line 1104:
> 1102: Java_sun_awt_screencast_ScreencastHelper_closeSession(JNIEnv *env,
> jclass cls) {
> 1103: }
> 1104:
Suggestion:
This doesn't seem necessary since this method should only be called if
`loadPipewire` returns true.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24009#discussion_r2006524200
