On Thu, 10 Apr 2025 12:02:45 GMT, Galder Zamarreño <gal...@openjdk.org> wrote:
> Avoid filtering out xml files at the root of the JMH folder, in order to get > the `default.instruments.template.xml` file bundled in the JMH core jar to > support xtrace profiler. The jmh-core jar file published in Maven central (https://repo.maven.apache.org/maven2/org/openjdk/jmh/jmh-core/1.37/jmh-core-1.37.jar), which is the one referenced from the devkit generator script, does not contain this `default.instruments.template.xml` file. The `rm` command seems to be aimed at `checkstyle.xml` and `findbugs.xml`, both of which I would assume to be irrelevant, but should also be benign, but I can't help but wonder why those files are included in the JMH distribution. In what kind of build configuration do you get `default.instruments.template.xml` bundled? Unfortunately, the original author of the JDK build logic for micro benchmarks isn't available atm. I don't know enough about JMH to say if this is a reasonable change. Maybe @shipilev can fill in with some knowledge? ------------- PR Comment: https://git.openjdk.org/jdk/pull/24571#issuecomment-2794585574
