On Mon, 28 Apr 2025 20:33:25 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> With that said, it is very much unclear why this line is here at all. The > removal of xml files is from the original integration of microbenchmarks, > JDK-8061281, and the reason behind it is lost in time. As I wrote above: >The rm command seems to be aimed at checkstyle.xml and findbugs.xml, both of >which I would assume to be irrelevant, but should also be benign, but I can't >help but wonder why those files are included in the JMH distribution. That was based on inspecting all 4 jars. I highly doubt there was anything more sinister or dangerous hidden in any of the jar files historically. These seemingly irrelevant files seem enough to have warranted this file removal to me at least. I do think it's a bug that JMH is bundling its checkstyle and findbugs configurations in its distribution jar, so perhaps we can suggest to a JMH maintainer to stop doing that. :) Regardless, the files should be benign so removing the `rm` line seems fine to me. ------------- PR Comment: https://git.openjdk.org/jdk/pull/24571#issuecomment-2836976702
