On Mon, 28 Apr 2025 13:34:29 GMT, kuaiwei <d...@openjdk.org> wrote: >> The patch fix error when creating devkit on wsl/msys2 . >> * Msys2 can be supported like cygwin >> * In wsl, it can not test path name in windows format, like `if [ -d >> "d:/VisualStuio"]` . The path must be converted as linux style before >> testing. >> * In msys2, `cmd.exe /c` doesn't work because "/c" is converted as "c:", it >> can be work around with `cmd.exe //c`. see >> https://superuser.com/questions/526736/how-to-run-internal-cmd-command-from-the-msys-shell >> >> I tested it with win10 + wsl/msys2 + VisualStudio 2022(17.13.6) > > kuaiwei has updated the pull request incrementally with one additional commit > since the last revision: > > Get SDK_INSTALL_DIR from enviroment variable
make/devkit/createWindowsDevkit.sh line 69: > 67: elif test "x$IS_MSYS" != "x"; then > 68: BUILD_ENV="cygwin" > 69: CMD_EXE="cmd.exe //c" The `//c` is a hacky solution. I think it would be better if you exported `MSYS2_ARG_CONV_EXCL="*"` -- you can do that without testing for windows environment since it does not really matter on anything but msys. Then you can skip `CMD_EXE` and keep the single-slash variant for all environments. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24916#discussion_r2064383756
